Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling USE_WEBSERVER does not disable USE_EMULATION #1592

Closed
0n3-70uch opened this issue Jan 13, 2018 · 4 comments
Closed

Disabling USE_WEBSERVER does not disable USE_EMULATION #1592

0n3-70uch opened this issue Jan 13, 2018 · 4 comments

Comments

@0n3-70uch
Copy link

0n3-70uch commented Jan 13, 2018 •
edited
Loading

Hello again,

I'm testing a lot of skill of your code now... Theo :-). I found another things but I'm not sure if it's correct or not.

I disabled USE_WEBSERVER and compiled the code. But after disabling USE_EMULATION I can safe 2k of code again. Don't know if it's normal but the USE_EMULATION is a subtopic of USE_WEBSERVER in the user_config.h.

Greetings Fabi
@arendst
Copy link
Owner

arendst commented Jan 13, 2018

It's caused by the emulation udp part which independant from webserver but I agree quite useless without a webserver....

@0n3-70uch
Copy link
Author

Ok, good information. Thanks :-).

@0n3-70uch
Copy link
Author

0n3-70uch commented Apr 10, 2018 •
edited
Loading

Hi just an update with version 5.12.0j. The compile size is based on my user_config_override.h.

#undef USE_WEBSERVER = 515.6kB

#undef USE_WEBSERVER and USE_EMULATION = 512.5kB

@0n3-70uch 0n3-70uch mentioned this issue Apr 10, 2018
Closed
4 tasks
arendst added a commit that referenced this issue Apr 10, 2018
@arendst
v5.12.0k - Fix two define changes
7a9ee6b 
5.12.0k
 * Prepare for simple rules by enlarging Settings area to now
2048 bytes
 * Fix freeing more code space when emulation is disabled
(#1592)
 * Fix compile error when not defined USE_TIMERS (#2400)
@0n3-70uch
Copy link
Author

Thanks for fixing.

@ascillato ascillato mentioned this issue Apr 10, 2018
Merged
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 6, 2018
@arendst
v5.12.0k - Fix two define changes
40498b7 
5.12.0k
 * Prepare for simple rules by enlarging Settings area to now
2048 bytes
 * Fix freeing more code space when emulation is disabled
(arendst#1592)
 * Fix compile error when not defined USE_TIMERS (arendst#2400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0n3-70uch @arendst