Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Ethernet in all safeboot firmware (except c2) #21983

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Jason2866
Copy link
Collaborator

Description:

Test of size increase of enabling Ethernet drivers in all safeboot firmwares except esp32-c2

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.4
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Sep 13, 2024
@Jason2866 Jason2866 removed the stale Action - Issue left behind - Used by the BOT to call for attention label Sep 13, 2024
Repository owner deleted a comment from github-actions bot Sep 13, 2024
@dkadioglu
Copy link

How is the status of this, will this be merged? As I just stumbled upon this, when I started an OTA update via LAN, and the ESP32 rebooted into safe boot and was not reachable anymore via LAN - took me some time to try it via Wifi. Would be nice to have this!

@nikito7
Copy link

nikito7 commented Oct 4, 2024

#14168 (reply in thread)

@Jason2866
Copy link
Collaborator Author

C6 safeboot goes over the partition size limit when Ethernet is enabled

@Jason2866 Jason2866 marked this pull request as draft October 5, 2024 11:03
@nikito7
Copy link

nikito7 commented Oct 5, 2024

C6 safeboot goes over the partition size limit when Ethernet is enabled

Something changed.
It worked some weeks ago.

Currently I only use S3

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Oct 5, 2024

@nikito7 Yes, nearly every day something is changed in or around Tasmota ;-)
I dd not merge the PR since this change was very close too the border. By the change to the new core it is too fat now.

@nikito7
Copy link

nikito7 commented Oct 5, 2024

I made a new variant. I don't know a better way too.
I need a variant anyway, because persistent defaults :)

At least a warning it's need in ota upgrade page.

How to force factory firmware to include my safeboot?

[env:tasmota32s3eth-safeboot]
extends                 = env:tasmota32_base
board                   = esp32s3-qio_qspi
board_build.app_partition_name = safeboot
build_flags             = ${env:tasmota32_base.build_flags}
                         -DFIRMWARE_SAFEBOOT
                         -DHAN_S3_ETH
                         -DUSE_SPI
                         -DUSE_ETHERNET
                         -UETH_TYPE
                         -DETH_TYPE=8
lib_extra_dirs          = lib/lib_ssl, lib/libesp32
lib_ignore              = ${safeboot_flags.lib_ignore}

...

[env:tasmota32s3eth]
extends                 = env:tasmota32_base
board                   = esp32s3-qio_qspi
build_flags             = ${env:tasmota32_base.build_flags}
                         -DFIRMWARE_TASMOTA32
                         -DHAN_S3_ETH
                         -UETH_TYPE
                         -DETH_TYPE=8
lib_ignore              = ${env:tasmota32_base.lib_ignore}
                          Micro-RTSP
                          epdiy

This work except factory bin.

I have to replace safeboot manually with esptool

@nikito7
Copy link

nikito7 commented Oct 5, 2024

I still recommend wifi for initial setup.

Some things are dependent on wifi.

Then:

autoexec.be

tasmota.cmd('Wifi 0')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants