Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard Thermostat With Web Controls #2486

Closed
wants to merge 10 commits into from

Conversation

IceStuff
Copy link

This is the code for the hard thermostat allowing control either heating or cooling on device for Sonoff TH. Control can be via webpage or MQTT.

Copy link
Contributor

@reloxx13 reloxx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add any new language keys at least in english in all other i18n files, if not, compiling will fail for other languages.

@arendst
Copy link
Owner

arendst commented Apr 20, 2018

Apart from the user interface is it's functionality not basically the same as a rule like:

{"Rule":"ON","Once":"ON","Rules":"on ds18b20#temperature>24 do power off endon on ds18b20#temperature<23 do power on endon"}

With variations in warming/cooling or other sensor type. Once the rule is configured the unit will perform like a thermostat standalone too.

@ascillato ascillato mentioned this pull request Jul 16, 2018
@sebfromme
Copy link

Guys, pls could I kindly ask you how to include IceStuffs code into my build or where to add arendsts rule? I'm highly interested in getting exactly this function.
Thx Seb

@alejlle
Copy link

alejlle commented Aug 11, 2018

When trying enable "#define USE_DS18x20" in user_config.h to attach more than one DS18B20 in the same GPIO, i received this error message:

E:\arduino-1.8.5\portable\sketchbook\sonoff\thermostat.ino: In function 'void ThermoFunction(int)':

thermostat:131: error: 'Ds18b20Read' was not declared in this scope

             if (Ds18b20Read(t))     // Check if read failed

                              ^

exit status 1
'Ds18b20Read' was not declared in this scope

@ascillato2
Copy link
Collaborator

Thanks for sharing your ideas. It is a good one. By now, This PR is not going to be merged due to be rebased from the actual code of Tasmota. Please, if you have further questions or ideas, do not hesitate on contacting us in the Tasmota Discord Chat. Thanks.

@ascillato2 ascillato2 closed this Oct 1, 2018
@gabrielklein
Copy link

gabrielklein commented May 3, 2019

I think this feature was great! What is missing to include it in the main code?

For people that don' t want to become crazy using rules and with some define to avoid "overloading" the code.

@ascillato ascillato mentioned this pull request Apr 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants