Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bitwarden secrets manager backend #657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Khabi
Copy link

@Khabi Khabi commented Aug 9, 2024

Description

Fixes:

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Bitwarden Secrets Manager addition.

The service has a free tier, so its helpful for home users labs.

Their SDK has a dependecy on CGO. I think that may be a sticking point in some projects, so I'm pointing it out ahead of time. That requires build changes to this repository to support it as well.

I see there is a Darwin build option, but I do not have access to validate that it works with the changes I've added.

Signed-off-by: Richard Cox <code@swrm.io>
Signed-off-by: Richard Cox <code@swrm.io>
@Khabi Khabi force-pushed the bitwarden_secrets_manaager branch from 66ad4b9 to 0741964 Compare August 9, 2024 16:48
@Khabi
Copy link
Author

Khabi commented Aug 9, 2024

If the CGO addition is going to be an issue then I completely understand. I'm not a huge fan of it myself, but I wasn't able to find a bitwarden library that was pure GO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant