fix image pull policy validation error #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiynesterenko90
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
Signed-off-by: Sergiy Nesterenko <sergiy@quilter.ai>
sergiynesterenko90
force-pushed
the
fix/image-pull-policy
branch
from
c34ecb5
to
5d72971
Compare
sambhav
added
semver:patch
|
@sergiynesterenko90 Thanks for this. Could you please add an example (which will also serve as a regression test)? You can see our contribution guidelines https://github.com/argoproj-labs/hera/blob/7f6bec0eb81449e6d47c0182f20608aeb7171841/CONTRIBUTING.md for more details. |
Signed-off-by: Sergiy Nesterenko <sergiy@quilter.ai>
|
@samj1912 thanks for the quick response! I've added an example, and auto-generated the golden copy + docs. Let me know if there's anything else needed! |
sambhav
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582
Basically, the
ScriptTemplatemodel expects a str for the imagePullPolicy definition, but hera is returning theImagePullPolicyenum - hence pydantic rejects it and throws an error. The fix is just to return the.valueof the enum instead of the enum itself.