fix: Fix argocd appset generate failure due to missing clusterrole (cherry-pick #20162) #20164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…20162) * fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com> * fix: update generated code Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com> --------- Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
crenshaw-dev
approved these changes
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #20164 +/- ##
================================================
+ Coverage 55.80% 55.81% +0.01%
================================================
Files 320 320
Lines 44382 44384 +2
================================================
+ Hits 24768 24775 +7
+ Misses 17050 17039 -11
- Partials 2564 2570 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Fix argocd appset generate failure due to missing clusterrole (#20162)
Signed-off-by: Pradithya Aria pradithya.pura@gojek.com
Signed-off-by: Pradithya Aria pradithya.pura@gojek.com
Signed-off-by: Pradithya Aria pradithya.pura@gojek.com