Skip to content

Commit

Permalink
chore(argo-rollouts): add option to disable creation of notifications…
Browse files Browse the repository at this point in the history
… configmap

This allows for using the upstream notifications configmap from
https://github.com/argoproj/argo-rollouts/blob/master/manifests/notifications-install.yaml

Signed-off-by: Roland Kool <rkool@bol.com>
  • Loading branch information
rolandkool committed Jul 26, 2024
1 parent 511d0d0 commit 961247b
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
4 changes: 3 additions & 1 deletion charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: v1.7.1
appVersion: v1.7.2
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.37.2
Expand All @@ -20,3 +20,5 @@ annotations:
artifacthub.io/changes: |
- kind: added
description: Added traefik.io apiGroup to Role and ClusterRole
- kind: added
description: Added setting to disable creation of the notifications ConfigMap
1 change: 1 addition & 0 deletions charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ For full list of changes please check ArtifactHub [changelog].
| keepCRDs | bool | `true` | Keep CRD's on helm uninstall |
| kubeVersionOverride | string | `""` | Override the Kubernetes version, which is used to evaluate certain manifests |
| nameOverride | string | `nil` | String to partially override "argo-rollouts.fullname" template |
| notifications.configmap.create | bool | `true` | Whether to create notifications configmap |
| notifications.notifiers | object | `{}` | Configures notification services |
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ if .Values.notifications.configmap.create }}
apiVersion: v1
kind: ConfigMap
metadata:
Expand All @@ -20,3 +21,4 @@ data:
subscriptions: |
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end }}
4 changes: 4 additions & 0 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ dashboard:
volumeMounts: []

notifications:
configmap:
# -- Whether to create notifications configmap
create: true

secret:
# -- Whether to create notifications secret
create: false
Expand Down

0 comments on commit 961247b

Please sign in to comment.