fix(argo-cd): remove secretName for server and applicationSet Certificates

[erwanval]

argocd-server and argocd-applicationset are expecting a secret with a predefined name, so having the option to set a custom name for the secret is confusing.

Related Issue:
#2724

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[jmeridth]

The default values that are assigned match the default values. You do not need to have them in your values.yaml and the default values will be set. I'm not a fan of this PR but await feedback from other maintainers.

[mkilchhofer]

I have no strict opinion here. I am fine with both.

But the changelog is wrong (you mentioned the wrong parameters).

[jmeridth]

Closing and reopening to see if DCO kicks off (was off and is on again)

[jmeridth]

Queue might be backed up still due to dcoapp/app#211. Can try again later.

[jmeridth]

UPDATE: Confirmed. DCO firing again. Thanks @mkilchhofer

@erwanval when you make the changes requested by @mkilchhofer, maybe a new commit will trigger the DCO app. We'll see.

[erwanval]

The default values that are assigned match the default values. You do not need to have them in your values.yaml and the default values will be set. I'm not a fan of this PR but await feedback from other maintainers.

If you keep the default, it works indeed. However, any other values than the default will be ignored, and the application will generate its own self-signed certificate instead. It still starts without error in appearance, but can cause confusion since the exposed cert doesn't match the one you configured.

@mkilchhofer Thanks for fixing the typo in changelog.
Regarding DCO, it seems to have been triggered now, but there is no "Verified" next to my commits somehow? I'm not sure if I'm missing something, it usually works just fine with other repositories.

[mkilchhofer]

Regarding DCO, it seems to have been triggered now, but there is no "Verified" next to my commits somehow? I'm not sure if I'm missing something, it usually works just fine with other repositories.

DCO is perfectly fine now (green rectangles). It was failing as the DCO GitHub app was not okay.

(The verified commits (gpg key or via GitHub GUI) are not required in argo-helm) :)

[yu-croco]

Hi @erwanval , can you please resolve conflict?

[erwanval]

@yu-croco done, thanks