Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-workflows): add configurable scrape interval for metrics and telemetry #2942

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(argo-workflows): add configurable scrape interval for metrics and telemetry #2942

merged 1 commit into from
Sep 27, 2024
+10 −4

Conversation

KrisF-Midnight
Copy link
Contributor

@KrisF-Midnight KrisF-Midnight commented Sep 27, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

tico24
tico24 requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once you have won the fight against DCO I'll kick off the CI. Thanks

@KrisF-Midnight
Copy link
Contributor Author

Looks good to me. Once you have won the fight against DCO I'll kick off the CI. Thanks

Thanks, is there any way to re-run the DCO checks? I've amended my commit with the signoff message.

@KrisF-Midnight
feat: add configurable scrape interval for metrics and telemetry
1432431 
Signed-off-by: KrisF-Midnight <krisztian.feher@iohk.io>
@tico24
Copy link
Member

tico24 commented Sep 27, 2024

Thanks, is there any way to re-run the DCO checks? I've amended my commit with the signoff message.

it already did :)

@yu-croco yu-croco merged commit 388c5ae into argoproj:main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-croco yu-croco yu-croco approved these changes

@tico24 tico24 tico24 approved these changes

@vladlosev vladlosev Awaiting requested review from vladlosev vladlosev is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

Assignees
No one assigned
Labels
argo-workflows size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrisF-Midnight @tico24 @yu-croco