Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #6

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Improve documentation #6

merged 1 commit into from
Feb 7, 2022

Conversation

arjun-1
Copy link
Owner

@arjun-1 arjun-1 commented Feb 7, 2022

  • Add various JSDocs
  • Add partition config to KafkaReader
  • Change KafkaGoSaur constructor to take enums

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #6 (0c42137) into master (6ff4ce4) will decrease coverage by 2.71%.
The diff coverage is 80.00%.

❗ Current head 0c42137 differs from pull request most recent head 6161da8. Consider uploading reports for the commit 6161da8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   66.36%   63.65%   -2.72%     
==========================================
  Files           9       10       +1     
  Lines         993     1051      +58     
  Branches        9       10       +1     
==========================================
+ Hits          659      669      +10     
- Misses        334      382      +48     
Impacted Files Coverage Δ
security/sasl.ts 100.00% <ø> (ø)
mod.ts 87.69% <72.72%> (-3.54%) ⬇️
net/connection.ts 100.00% <100.00%> (ø)
net/deno-connection.ts 2.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3830af...6161da8. Read the comment docs.

* Add various JSDocs
* Add `partition` config to KafkaReader
* Change `KafkaGoSaur` constructor to take enums
@arjun-1 arjun-1 merged commit 4dc7707 into master Feb 7, 2022
@arjun-1 arjun-1 deleted the add-docs branch February 7, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants