Complete upstream operatorhub.io integration #676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusdev
reviewed
Aug 24, 2023
| @@ -2050,7 +2050,7 @@ spec: | |||
| fieldPath: metadata.annotations['olm.targetNamespaces'] | |||
| - name: ENABLE_WEBHOOKS | |||
| value: "false" | |||
| image: quay.io/artemiscloud/activemq-artemis-operator:1.0.14 | |||
| image: quay.io/msarawan/operator:1.0.14 | |||
There was a problem hiding this comment.
NO Domenico, it is still work in progress repo so i tested on my local image. so i converted draft PR for now.
config/manager/kustomization.yaml
Outdated
| @@ -17,5 +17,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: quay.io/artemiscloud/activemq-artemis-operator | |||
| newName: quay.io/msarawan/operator | |||
|
Hi @Msarawan , in the end we should be using the upstream image name in the CSV file. When using your own image you can use 'make bundle' to update the CSV automatically. |
Msarawan
added a commit
to Msarawan/activemq-artemis-operator
that referenced
this pull request
Aug 25, 2023
… Lifecycle Manager(OLM)
Msarawan
force-pushed
the
operatorhub-integration
branch
from
f08fae4
to
3cf7fe6
Compare
Msarawan
force-pushed
the
operatorhub-integration
branch
from
3cf7fe6
to
6fb447b
Compare
Msarawan
added a commit
to Msarawan/activemq-artemis-operator
that referenced
this pull request
Sep 18, 2023
Msarawan
force-pushed
the
operatorhub-integration
branch
from
6fb447b
to
8d5193c
Compare
Msarawan
force-pushed
the
operatorhub-integration
branch
from
8d5193c
to
12c4990
Compare
Msarawan
added a commit
to Msarawan/activemq-artemis-operator
that referenced
this pull request
Sep 20, 2023
Msarawan
added a commit
to Msarawan/activemq-artemis-operator
that referenced
this pull request
Sep 20, 2023
Msarawan
added a commit
to Msarawan/activemq-artemis-operator
that referenced
this pull request
Sep 20, 2023
brusdev
force-pushed
the
main
branch
5 times, most recently
from
a9861a2
to
6ea4c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important for the visibility of the broker operator to have it made available via the community operator.io.