Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for all the components in the addresses/address-details #250

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

Msarawan
Copy link
Collaborator

Added unit tests for AddressDetailsRow component

@Msarawan Msarawan added this to the Stabilize the UI milestone Jul 29, 2024
@Msarawan Msarawan self-assigned this Jul 29, 2024
@Msarawan Msarawan force-pushed the AddressRowTest branch 4 times, most recently from 8423c54 to 8b1deb9 Compare July 29, 2024 09:24
Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, I'm wondering if there's more we could test?

@Msarawan
Copy link
Collaborator Author

That looks good to me, I'm wondering if there's more we could test?

Yes, within AddressDetails we have 3 components we need to write tests for all 3 components. because it involves logic of query client and AuthContext so we need to check for all the components.

@lavocatt
Copy link
Collaborator

That looks good to me, I'm wondering if there's more we could test?

Yes, within AddressDetails we have 3 components we need to write tests for all 3 components. because it involves logic of query client and AuthContext so we need to check for all the components.

Can you add these too in the PR please?

@Msarawan Msarawan force-pushed the AddressRowTest branch 3 times, most recently from eac2265 to 341f00f Compare July 31, 2024 16:06
@Msarawan Msarawan changed the title Add unit tests for AddressDetailsRow component Add unit tests for all the components in the addresses/address-details Aug 1, 2024
gaohoward
gaohoward previously approved these changes Aug 1, 2024
Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!

@lavocatt lavocatt merged commit 90eb0a9 into artemiscloud:main Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants