[#198] the yaml editor allows to enter new Lines #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavocatt
force-pushed
the
yamleditor
branch
2 times, most recently
from
fe4e948
to
9a2ded9
Compare
|
This PR is currently blocked on https://issues.redhat.com/browse/OCPBUGS-38484 |
lavocatt
force-pushed
the
yamleditor
branch
2 times, most recently
from
69ff645
to
b372fd4
Compare
Upgrading to patternfly5 fixed the issue for us. |
|
Hello @lavocatt , could you please rebase the branch with the main branch. |
lavocatt
force-pushed
the
yamleditor
branch
2 times, most recently
from
e01fcd3
to
de73446
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 46.68% 46.68% -0.01%
==========================================
Files 52 52
Lines 2296 2311 +15
Branches 645 652 +7
==========================================
+ Hits 1072 1079 +7
- Misses 1224 1232 +8 ☔ View full report in Codecov by Sentry. |
Previously the yaml editor wasn't allowing a user to add new lines. This was because at each keystroke the yaml file got formatted automatically, removing what formatting felt as unnecessary lines.. This meant that the user had to use tricks like copy&pasting to get to a state the wanted to have. To fix that, this commits reverts back to using the resource editor provided by the console. It has several advantages: * The use can edit the file as they want without bugs * There's documentation included from the CRDs when hovering properties The main drawback is that the user needs to click on save to save their changes to the model, then needs to click on apply to apply their config (either creating or updating) Other additions: ---------------- In order to make the logic of the buttons the same between the two views, they have been extracted up a notch in the component hierarchy. Warning modals have been added to help the user know if they are about to lose some changes. A reload button was added to the update broker page, so that the user can reload the content of the existing broker.
lavocatt
force-pushed
the
yamleditor
branch
from
de73446
to
146eb2b
Compare
Msarawan
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the yaml editor wasn't allowing us to add new lines. This was because at each keystroke the yaml file was formated automatically, removing unecessary lines..
This meant that the user had to use tricks like copy&pasting to get to a state the wanted to have.
To fix that, this commits reverts back to using the resource editor provided by the console. It has several advantages:
The main drawback is that the user needs to click on save to save their changes to the model, then needs to click on apply to apply their config (either creating or updating)
fixes #198