Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unique port numbers for acceptors and connectors separately #281

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Msarawan
Copy link
Collaborator

@Msarawan Msarawan commented Aug 30, 2024

  • Updated the logic to generate unique port numbers for acceptorsand connectors separately.
  • Updated unit test to verify the unique port assignment for both acceptors and connectors separately.

fixes: #279

@Msarawan Msarawan added the bug Something isn't working label Aug 30, 2024
@Msarawan Msarawan added this to the Stabilize the UI milestone Aug 30, 2024
@Msarawan Msarawan self-assigned this Aug 30, 2024
@Msarawan Msarawan marked this pull request as ready for review August 30, 2024 08:04
Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work.

Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the two commits together please?

…nectors separately

Updated the logic to generate unique port numbers for acceptors and connectors separately.
Updated unit test to verify the unique port assignment for both acceptors and connectors separately.
@lavocatt lavocatt merged commit 0136469 into artemiscloud:main Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate unique port numbers for acceptors and connectors separately
2 participants