This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
Fix Russian locale file key #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading the Vanity dashboard with an English locale, all the interface text was being shown in Russian. We _think_ this is because the Russian locale file uses the `en:` key, and as it loads after the English locale it is overwriting the English values. We've updated the Russian locale to use the `ru:` key.
|
Just bumping this, any chance of getting this reviewed please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the Vanity dashboard with an English locale, all the
interface text was being shown in Russian.
We think this is because the Russian locale file uses the
en:key,and as it loads after the English locale it is overwriting the English
values.
We've updated the Russian locale to use the
ru:key.