Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid false-positives for list concatenations in SQL construction #12720

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Avoid false-positives for list concatenations in SQL construction #12720

merged 1 commit into from
Aug 6, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #12710.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 6, 2024
@charliermarsh charliermarsh merged commit 90e5bc2 into main Aug 6, 2024
20 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -3 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)

python/typeshed (+1 -3 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

- stubs/tensorflow/tensorflow/compiler/xla/xla_pb2.pyi:2165:5: F821 Undefined name `DESCR`
- stubs/tensorflow/tensorflow/compiler/xla/xla_pb2.pyi:2177:27: F821 Undefined name `UnpackResponse`
- stubs/tensorflow/tensorflow/compiler/xla/xla_pb2.pyi:2181:5: PYI021 Docstrings should not be included in stubs
+ stubs/tensorflow/tensorflow/compiler/xla/xla_pb2.pyi:2198:5: PYI021 Docstrings should not be included in stubs

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PYI021 2 1 1 0 0
F821 2 0 2 0 0

@charliermarsh charliermarsh deleted the charlie/s branch August 6, 2024 20:26
dylwil3 pushed a commit to dylwil3/ruff that referenced this pull request Aug 7, 2024
@charliermarsh @dylwil3
Avoid false-positives for list concatenations in SQL construction (as…
dc9c300 
…tral-sh#12720)

## Summary

Closes astral-sh#12710.
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive hardcoded-sql-expression (S608)
1 participant
@charliermarsh