Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inappropriate patch release of 0.10.2. #42

Closed
romanb opened this issue Dec 7, 2020 · 3 comments
Closed

Inappropriate patch release of 0.10.2. #42

romanb opened this issue Dec 7, 2020 · 3 comments

Comments

@romanb
Copy link

romanb commented Dec 7, 2020

0.10.2 seems to have been an inappropriate patch release, as it bumps rustls from 0.18 to 0.19 and rustls types are part of the public API of async-tls. This can cause downstream builds to fail (libp2p/rust-libp2p#1873). See #26 (comment) for an analogous prior occurrence. Maybe 0.10.2 should be yanked and republished as 0.11, as in the earlier occurrence.
@romanb romanb mentioned this issue Dec 7, 2020
Closed
@dcreager dcreager mentioned this issue Dec 8, 2020
Merged
rhymu8354 added a commit to rhymu8354/HttpClient that referenced this issue Dec 8, 2020
@rhymu8354
Fix build issue caused by async-tls change
e14b62d 
async-tls updated the patch version but internally
depends on rustls update from 0.18 to 0.19.

See: async-rs/async-tls#42
rhymu8354 added a commit to rhymu8354/HttpServer that referenced this issue Dec 8, 2020
@rhymu8354
Fix build issue caused by async-tls update
e99e8da 
async-tls updated the patch version but internally
depends on rustls update from 0.18 to 0.19.

See: async-rs/async-tls#42
@mxinden mxinden mentioned this issue Dec 9, 2020
Merged
@romanb
Copy link
Author

romanb commented Dec 9, 2020

Since quite a few downstream projects seem to have already necessarily updated to both async-tls-0.10.2 and rustls-0.19, I guess this ship has sailed and yanking now would just cause more problems.

@romanb romanb closed this as completed Dec 9, 2020
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 9, 2020

As one of the affected downstream maintainers, I would be happy to update again if 0.10.2 is yanked.

@skade
Copy link
Collaborator

skade commented Dec 9, 2020 •
edited
Loading

Hi, sorry for the late reply. I yanked 0.10.2 and re-released it as 0.11.0.

(FWIW, one of the reasons why I want to avoid exposing rusttls types, or rather even reduce their usage, as much as possible is this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrubeck @skade @romanb