-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handler interface is too restricted #52
Comments
It kinda looks like string was used to satisfy |
Oh man. When was the last time the tests were run?
jwt-go Going to take a bit just to get the tests functioning, before I can even dig into making changes. Buckle up, this is going to be a bumpy ride. |
Yeah, I also agree, the Error Handler is way too restricted ! |
I apologize for the silence on this issue and the PR. We are ramping up work on |
We just released the v2.0.0-beta 🥳 ! You can start testing it by running In case of issues fetching the v2 you might want to try I'm closing this issue as now this is part of v2, but feel free to reopen if needed. |
Hello! Right now you have type errorHandler:
type errorHandler func(w http.ResponseWriter, r *http.Request, err string)
i think, it seems too restricted, because type of err is string, instead of error. In case of type error, interface will be more Go-ideomatic. And in the client error handler it will be possible to operate with types, not strings:
instead:
What do you think?
The text was updated successfully, but these errors were encountered: