Make errorHandler take error instead of string #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Make error handler take an
error
instead of a string. This is a much more powerful API, especially since Go 1.13, as nested errors can now be extracted. I didn't introduce any%w
wrapped errors as I wasn't sure which versions of Go you support.This is technically a breaking change, as it changes the accepted values given to
ErrorHandler
in theOptions
struct. I did notice that there hasn't been v1 release of this package yet (technicallyv0.0.0-whatever
still as reported ingo.mod
) so I'm raising this PR in the hope that breaking changes are still accepted.Changes error messages to start with a lower case character.
Added missing note about what the default value is for
ErrorHandler
References
Fixes #52.
Testing
Change can be tested by using the package as described and passing in an
Extractor
in Options that always returns an error.Tests pass on my local MBP dev machine.
Checklist
master