Added support for /users-by-email method. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handled by a new ```getUsersByEmail``` method
|
Thanks for the PR. Can you also add a test so we make sure we don't add bugs in the future? Thanks! |
I just copied and modified the tests from getAll, so hopefully this is what was expected!
|
Sure thing, I just added in the tests that were used by getAll, so hopefully that's OK! |
hzalaz
approved these changes
Nov 8, 2017
|
Is there an ETA on releasing this? 😁 |
|
@hzalaz It has been nearly a month since this was merged. Any chance for a release? |
|
Released in 2.9.0. Thank you, @hzalaz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/users-by-emailAPI is preferred over using the Search API when working in the Authentication workflow. This is because the Search API uses Elastic Search and is less reliable than the single-index lookup provided by/users-by-emailThis new API allows you to use a simplified API:
I copied the
getUsersmethod style, and did separate testing of my own to verify this works. Feel free to make any suggestions or improve.