Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed missing data object error #224

Merged
merged 1 commit into from
Dec 8, 2017
Merged

fixed missing data object error #224

merged 1 commit into from
Dec 8, 2017

Conversation

dctoon
Copy link
Contributor

@dctoon dctoon commented Dec 8, 2017

Fixes issue #223

Following code delete args[X]; does not change the length of the array. This caused an error in the depended rest-facade library.

Solution, convert the array-like arguments object to an array, and remove the item so the length property is correct.

@aaguiarz aaguiarz merged commit 9c1f1bd into auth0:master Dec 8, 2017
@hzalaz hzalaz added this to the v2.9.1 milestone Dec 8, 2017
@luisrudge luisrudge mentioned this pull request Dec 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v2.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dctoon @luisrudge @hzalaz @aaguiarz