Add send_completion_email and upsert params for importUsers #270
Conversation
… endpoint # Conflicts: # src/management/JobsManager.js
|
are the default values the same as the server? |
|
I thought they were, but https://auth0.com/docs/api/management/v2#!/Jobs/post_users_imports doesn't seem to actually list any defaults. Maybe there shouldn't be a default. |
|
Yeah, let's not add defaults for this params. |
1 similar comment
|
Yeah, let's not add defaults for this params. |
|
In my PR i set it to true because on this page: https://auth0.com/docs/users/migrations/bulk-import it states send_completion_email - A boolean value which when set to true, sends a completion email to all tenant owners when the job is finished. The default is true, so you must explicitly set this parameter to false if you do not want emails sent. in fact, the original reason I added the parameter for myself in the SDK is because while developing i was getting emails every time i tested it, so i wanted to be able to turn those off. |
|
Ok, cool. What about upsert? |
|
Upsert should default to false. (as it does in this PR) From that same page: Upsert - A boolean value, false by default. If it is false, users will only be inserted. If there are already user(s) with the same emails as one or more of those being inserted, they will fail. If this value is set to true and the user being imported already exists, the user will be updated with the new information. |
|
ok that's perfect. please rebase and I'll merge |
|
Thanks @mikemeerschaert I thought they were default but was looking in the wrong place. Fixing conflicts now. |
|
this is ready to go, any chance of a merge? |
luisrudge
changed the title
|
Sorry about the wait! I'll cut a new release this week 🎉 |
Bringing in @mikemeerschaert's parameter changes from #243 and adding tests.