Add Guardian Enrollments endpoints #278
Conversation
|
Thanks for this, can you rebase against mater please. I'll ensure this is reviewed. @luisrudge |
|
@cocojoe done it and it seems our branches are in sync. Please let me know if you need anything. |
|
I can update for you but prefer people to rebase. |
|
@cocojoe @luisrudge do you want something else from me that could help it to get reviewed? |
|
@fmedinac can you rebase please |
|
@cocojoe PR seem to be synced with upstream. Do you need anything else in order to get this merged in? Would love to have it available. |
|
I'll review this tomorrow. |
|
@luisrudge Thank you. If you need any help to get this in feel free to ping me. I can help. |
src/Auth0RestClient.js
Outdated
| @@ -61,6 +61,10 @@ Auth0RestClient.prototype.patch = function(/* [params], [callback] */) { | |||
| return this.wrappedProvider('patch', arguments); | |||
| }; | |||
|
|
|||
| Auth0RestClient.prototype.post = function(/* [params], [callback] */) { | |||
| return this.wrappedProvider('post', arguments); | |||
There was a problem hiding this comment.
we don't need 'post'. you have to use 'create', which is already being used through out the code base.
|
Hi @rafaelrinaldi and @fmedinac. I left just a single comment. Can you write a quick script file that uses all the new methods so I can test that they're correctly communicating with the API? |
|
@luisrudge I've created a repository for testing it. See if it helps: https://github.com/fmedinac/node-auth0-278-poc Please see if it works for you. |
|
@luisrudge No rush, just want to check and see how things are looking. We can make any changes necessary so this can get merged, just let us know. |
|
Sorry. Took me a while to get to this! Thank you so much for the repo, it was super easy to test the changes! |
|
@luisrudge Any idea as of when this change is gonna get published as a new release? |
|
Hi, we just published 2.12.0. Sorry about the wait! |
This PR adds two new methods on
management:getGuardianEnrollmentfor getting a single guardian enrollmentdeleteGuardianEnrollmentfor deleting a guardian enrollmentNote that this PR doesn't include other methods for all the endpoints described on https://auth0.com/docs/api/management/v2#!/Guardian that might be included in future PRs in order to close #249.
Closes #168 (already closed)
Update (July 3, 2018)
Added a new endpoint for regenerating the recovery code (ref: https://auth0.com/docs/api/management/v2#!/Users/post_recovery_code_regeneration)