Add client secret to refreshToken and remove ID token validation #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Oct 17, 2019
joshcanhelp
commented
Oct 17, 2019
joshcanhelp
commented
Oct 17, 2019
joshcanhelp
requested review from
stevehobbsdev and
a team
and removed request for
stevehobbsdev
joshcanhelp
requested review from
stevehobbsdev
and removed request for
stevehobbsdev
lbalmaceda
reviewed
Oct 29, 2019
| expect(request.isDone()).to.be.true; | ||
| done(); | ||
| }) | ||
| .catch(done); |
There was a problem hiding this comment.
wouldn't calling done imply the test is over successfully? And if so, I don't think we want that for the case where something goes wrong like here that an exception is thrown.
There was a problem hiding this comment.
Honestly, I'm not totally sure. This is only one of a few tests for refreshToken and we're just looking for something specific, that the secret is there.
|
@lbalmaceda - Ready for you again! |
lbalmaceda
approved these changes
Dec 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
References
#432
Testing