-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Hooks API #440
Conversation
@damieng can you review, please. You may need to tweak the codecov here for a little leeway. I ran into this with Swift. https://github.com/auth0/Auth0.swift/blob/master/codecov.yml Also if pages isn't actually doing anything useful? Let's remove that status check. Also curious as to how this will fit into generated SDKs. |
Does this supersede #438 ? |
We reviewed the hooks API before it was public - it should fit fine into the code generation if the Swagger is correct/as proposed. This project has full docs at https://auth0.github.io/node-auth0/ so I'm concerned about switching off the GH Pages check. I'll dig in and see what's going on there. |
Is this now ready to merge? What else are we waiting on @astanciu |
@damieng We can wait until GA is rolled out or merge now. |
Co-Authored-By: Damien Guard <damieng@gmail.com>
Changes
Adds support for Hooks API:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist