Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Hooks API #440

Merged
merged 6 commits into from
Jan 23, 2020
Merged

Support for Hooks API #440

merged 6 commits into from
Jan 23, 2020

Conversation

astanciu
Copy link
Contributor

@astanciu astanciu commented Dec 10, 2019

Changes

Adds support for Hooks API:

  • Adds HooksManager class
  • Adds support for hook secrets
  • Adds wrappers: getHook, getHooks, createHook, updateHook, deleteHook, getHookSecrets, addHookSecrets, updateHookSecrets, removeHookSecrets

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

  • All existing and new tests complete without errors

@astanciu astanciu requested a review from a team December 10, 2019 19:57
@cocojoe
Copy link
Member

cocojoe commented Dec 12, 2019

@damieng can you review, please. You may need to tweak the codecov here for a little leeway. I ran into this with Swift.

https://github.com/auth0/Auth0.swift/blob/master/codecov.yml

Also if pages isn't actually doing anything useful? Let's remove that status check.

Also curious as to how this will fit into generated SDKs.

@damieng
Copy link
Contributor

damieng commented Dec 12, 2019

Does this supersede #438 ?

@damieng
Copy link
Contributor

damieng commented Dec 12, 2019

We reviewed the hooks API before it was public - it should fit fine into the code generation if the Swagger is correct/as proposed.

This project has full docs at https://auth0.github.io/node-auth0/ so I'm concerned about switching off the GH Pages check. I'll dig in and see what's going on there.

@davidpatrick davidpatrick removed the request for review from a team January 10, 2020 18:30
@damieng
Copy link
Contributor

damieng commented Jan 22, 2020

Is this now ready to merge? What else are we waiting on @astanciu

@faroceann
Copy link
Contributor

faroceann commented Jan 22, 2020

@damieng We can wait until GA is rolled out or merge now.

@damieng damieng changed the title DO NOT MERGE: Support for Hooks API Support for Hooks API Jan 22, 2020
src/management/HooksManager.js Outdated Show resolved Hide resolved
Co-Authored-By: Damien Guard <damieng@gmail.com>
@damieng damieng merged commit 2169ebf into auth0:master Jan 23, 2020
@davidpatrick davidpatrick added this to the v2.22.0 milestone Jan 24, 2020
@davidpatrick davidpatrick mentioned this pull request Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants