Allow passwordless SMS code verification to use token endpoint #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
force-pushed
the
allow-sms-code-to-use-token-ep
branch
from
f8e2887
to
ac04df1
Compare
davidpatrick
approved these changes
Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
verifySMSCodemethod on theAuthenticationClientdelegates to thesignInmethod of thePasswordlessAuthenticator. It only passed theusernameandpassword, which results in calling the deprecated/oauth/roendpoint to authenticate. With the addition of #556, passing theotpwill result in calling the/oauth/tokenendpoint to authenticate.This change allows sending the
otpoption when callingverifySMSCode, which will enable using the token endpoint instead of/oauth/ro. Callers passing acodeorpasswordwill still use the/oauth/roendpoint.References
#556
Checklist