Update jsonwebtoken #766
Merged
Update jsonwebtoken #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am investigating the Node 16 & 18 failures |
This was referenced Dec 22, 2022
☝️ due to a testing dependency not working on openssl 3 (which the new |
adamjmcgrath
commented
Dec 22, 2022
| @@ -3,7 +3,7 @@ const sinon = require('sinon'); | |||
| const proxyquire = require('proxyquire'); | |||
| const jwt = require('jsonwebtoken'); | |||
| const jwksClient = require('jwks-rsa'); | |||
| const pem = require('pem'); | |||
There was a problem hiding this comment.
pem (testing only dependency) doesn't work on openssl 3 which the new cimg images use
frederikprijck
approved these changes
Dec 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update jsonwebtoken
Breaking change: Drop support for Node <14
(Have gone with Node >=14 even though
jsonwebtokenonly requires 12 because 12 is EOL and we'll want to follow up with an upgrade ofjwks-rsawhich requires >=14)References
Fixes #763
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist