Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing endpoint and model properties #866

Merged
merged 2 commits into from
May 22, 2023

Conversation

frederikprijck
Copy link
Member

Changes

This PR adds the missing endpoint for deleting multiple authentication methods, it also adds some missing model properties and updates some comments.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

adamjmcgrath
adamjmcgrath previously approved these changes May 22, 2023
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frederikprijck frederikprijck marked this pull request as ready for review May 22, 2023 09:15
@frederikprijck frederikprijck requested a review from a team as a code owner May 22, 2023 09:15
@frederikprijck frederikprijck enabled auto-merge (squash) May 22, 2023 09:29
@frederikprijck frederikprijck merged commit 2e0cd23 into beta May 22, 2023
@frederikprijck frederikprijck deleted the fix/missing-endpoints branch May 22, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants