Add support for userInfo endpoint #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if the Users service should not be part of AuthenticationClient, since we don't want to require users to provide a We should probably just export UsersClient along with AuthenticationClient and ManagementClient |
|
Or we could make |
|
Thinking about it from the Auth0 side, it's part of the Authentication API docs. I am happy with both, but leaning towards part of AuthApi (it also was like that before). Happy to make clientId optional and run-time check in the base-auth-api. |
frederikprijck
force-pushed
the
feat/auth-users
branch
from
c5c3211
to
ecccb64
Compare
|
Updated the PR to ensure the UserInfoClient is a separate client instead of a sub-client on the Auth side. |
adamjmcgrath
previously approved these changes
Jul 18, 2023
|
I missed telemetry and some tests, updated. |
adamjmcgrath
approved these changes
Jul 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for the userInfo endpoint, which we missed in the initial beta.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist