Fix issue with TS rewriting fetch dynamic imports #878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
https://github.com/auth0/node-auth0/releases/tag/v4.0.0-beta.4 broke the CJS version of the Beta because TypeScript was rewriting the
node-fetch@3
dynamic imports. (see microsoft/TypeScript#43329)The suggestion to use
moduleResolution: node16
works (havenpm pack
d and tested native esm and cjs) - I've diffed the build and the only differences are the removal of transpiled imports.Will add some automated tests to make sure we don't break the exports again... 🤦