Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1134 Add possibility to automatically close popup window after som… #1146

Conversation

kwojtasinski-repo
Copy link
Contributor

…e time

Closes/fixes #issue

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (d1c9354) 77.82% compared to head (10b57ab) 77.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files          45       45           
  Lines        1718     1723    +5     
  Branches      341      343    +2     
=======================================
+ Hits         1337     1341    +4     
  Misses        341      341           
- Partials       40       41    +1     
Flag Coverage Δ
unittests 77.82% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/UserManagerSettings.ts 98.30% <ø> (ø)
src/utils/PopupUtils.ts 70.00% <ø> (ø)
src/navigators/PopupWindow.ts 86.66% <80.00%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/UserManagerSettings.ts Outdated Show resolved Hide resolved
src/UserManagerSettings.ts Outdated Show resolved Hide resolved
@pamapa
Copy link
Member

pamapa commented Aug 28, 2023

see #798

@kwojtasinski-repo kwojtasinski-repo force-pushed the 1134_automatic_close_window_after_some_time branch from 0b5fc34 to 98a35a4 Compare August 30, 2023 18:51
@pamapa pamapa added the enhancement New feature or request label Aug 31, 2023
src/UserManagerSettings.ts Outdated Show resolved Hide resolved
@kwojtasinski-repo kwojtasinski-repo force-pushed the 1134_automatic_close_window_after_some_time branch from 28f4445 to 10b57ab Compare August 31, 2023 21:47
@pamapa
Copy link
Member

pamapa commented Sep 1, 2023

thanks for contributing

@pamapa pamapa added this to the 2.3.0 milestone Sep 1, 2023
@pamapa pamapa merged commit 460578d into authts:main Sep 1, 2023
4 checks passed
@kwojtasinski-repo
Copy link
Contributor Author

kwojtasinski-repo commented Sep 1, 2023

thanks for contributing

You are welcome. I tested this solution today and unfornatelly the window didn't close after some time. I thought that method abort will handle. I can add this._window.close() when the window is not closed or maybe I should use directly method this.close? Today I can add next PR which fix this

@pamapa
Copy link
Member

pamapa commented Sep 4, 2023

sorry to hear that, yes please provide a working fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants