Fix too early UserManager.events().unload() event before user is actually signed out
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
+ Coverage 78.33% 79.78% +1.44%
==========================================
Files 45 45
Lines 1731 1731
Branches 344 344
==========================================
+ Hits 1356 1381 +25
+ Misses 338 312 -26
- Partials 37 38 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pamapa
reviewed
Jan 15, 2024
…s actually signed out Prevents race conditions with event handlers which react to this unload event and expect the user to be signed out already. Fixes authts#1341
PSanetra
force-pushed
the
fix-too-early-user-unloaded-event
branch
from
4acc543
to
1ad5d00
Compare
pamapa
approved these changes
Jan 15, 2024
|
thanks for contributing |
|
@pamapa Thank you for reacting so fast! 🚀 |
|
@PSanetra Yes, i can make one in the next few days (1-3)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents race conditions with event handlers which react to this unload event and expect the user to be signed out already.
Fixes #1341