Upgrade Substrate and Frontier #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith-db` is it not really necessary
…orresponding Frontier fork updates
nazar-pc
requested review from
vedhavyas,
NingLin-P,
rg3l3dr and
shamil-gadelshin
as code owners
nazar-pc
force-pushed
the
upgrade-substrate
branch
from
5f0db3e
to
6b542f4
Compare
vedhavyas
previously approved these changes
Sep 13, 2023
Recall what it looked like 2 years ago. I hope they will get to attribute macro there at some point too 🙂 |
|
Okay, looks like something else related to transaction pool needs to be changed to fix tests 😕 |
|
@vedhavyas @NingLin-P I'll need your help fixing domains tests here |
|
Interesting, looks like to be able to submit transactions this is now required: Let me fix this and see if tests pass. |
NingLin-P
reviewed
Sep 13, 2023
vedhavyas
previously approved these changes
Sep 13, 2023
|
Is it possible to register the extension just once like |
|
I believe it should be possible, but it is also recommended to not do that. |
rahulksnv
previously approved these changes
Sep 13, 2023
We had to introduce Inherent data providers since upstream introduced `pending` tags for Eth rpc calls. When an rpc call with pending tag is received, we construct pending block by building a new block with extrinsics from tx pool. So they use inherent data providers to provide inherent data. For now, we just provide timestamp since that is always required. I have added an TODO to handle any new inherents that needs to be present. Ex runtime upgrade can be added in later PR
Upgrade frontier deps
vedhavyas
previously approved these changes
Sep 13, 2023
|
Hm, merge conflicts already 😒 |
# Conflicts: # crates/subspace-node/Cargo.toml # crates/subspace-node/src/domain/cli.rs
1 task
NingLin-P
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontier updates are done in polkadot-evm/frontier#1193, Substrate updates are done in
subspace-v6branch in our fork (rebased due to various conflicts, primarily with block relay).This upgrades us to latest commit in the old Substrate repo, I'll upgrade us to latest
polkadot-sdkin a separate PR.Interesting changes:
GasLimitPovSizeRatio,weight_limitandproof_size_base_costwere introduced, seem to be parachain-specific and set to defaults.pendingsupport foreth_getBlockByNumber: Addpendingsupport foreth_getBlockByNumberpolkadot-evm/frontier#1048Introduced
pending_blockRPC runtime API, I used implementation from template in the PROther important upstream changes that resulted in downstream modifications:
GenesisBuild<T,I>deprecated.BuildGenesisConfigadded. paritytech/substrate#14306Blocktoframe_systeminstead ofconstruct_runtimeand removesHeaderandBlockNumberparitytech/substrate#14437paritytech/substrate#14709 was promising, but not sufficient, so I opened paritytech/polkadot-sdk#1533
Code contributor checklist: