Add timer config option #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-bechanko
commented
May 20, 2022
alex-bechanko
commented
- Adds a config option that lets you swap out the timer used within the library.
- Mainly useful for testing purposes or sharing the same timer object/module in a user's repo with the library.
Add support for contexts during infinite attempts
|
Sorry, I hadn't meant to open this quite yet but now realize that probably didn't matter. I'm re-opening this now that I think it's ready. |
alex-bechanko
force-pushed
the
timer-interface
branch
from
ed0d7cb
to
2991621
Compare
JaSei
approved these changes
Jun 10, 2022
|
Thank you for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.