Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning in docs generation #159

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fix warning in docs generation #159

merged 1 commit into from
Nov 26, 2023

Conversation

robertchristensen
Copy link
Contributor

Fixes warnings in docs generations:

  1. Two links in docs in functions in the Curve trait were not correctly referenced, so I added references to the functions they were trying to reference.
  2. Two links in portfolio.rs had redundant information when referencing other parts of the code causing errors in docs generation so they were removed.

After this I don't see any warning in docs generation when I build locally, and I the links go to the functions.

Signed-off-by: Robert Christensen <robert.christensen@gmail.com>
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13c37a0) 69.13% compared to head (217503f) 69.13%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files         104      104           
  Lines        3690     3690           
=======================================
  Hits         2551     2551           
  Misses       1139     1139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avhz avhz merged commit c7def1d into avhz:main Nov 26, 2023
7 checks passed
@avhz
Copy link
Owner

avhz commented Nov 26, 2023

Awesome, thank you very much !

@github-actions github-actions bot mentioned this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants