Fixes block and proc definition to work with Ruby 3.0.0 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csalvato
changed the title
|
I think that this PR also resolve #382. |
|
@csalvato Did you notice that in Ruby 2.4 for rails_5.0.gemfiles, rails_5.1.gemfiles, rails_5.2.gemfiles did not pass the test? |
|
Hm, I did...not quite sure how to address it 🤔 |
BryanH
approved these changes
Jan 13, 2021
|
This is my first OSS contribution 🎉 Thanks all :) |
This was referenced Mar 8, 2021
jclusso
added a commit
to jclusso/awesome_print
that referenced
this pull request
Jul 19, 2022
* source/master: Update PRY integration section (awesome-print#411) BigDecimal required; test fixes for ruby 3 (awesome-print#408) Bump canonical (awesome-print#406) Ruby 2.6, 2.7 and 3 fixes (awesome-print#405) Added canonical for rubygems (awesome-print#401) Updated nokogiri to fix vulnerability scan failures (awesome-print#400) Corrected bug in examples (issue awesome-print#326); added example headers (awesome-print#398) Updated config to remove deprecations (awesome-print#397) Update CHANGELOG & fixed travis fails (awesome-print#394) Added mongoid 7 gemsets; ignore vendor/bundle (awesome-print#395) Added rails 6.0 and 6.1 tests to travis (awesome-print#396) Fix method signature after change in IRB (awesome-print#390) Fixes block and proc definition to work with Ruby 3.0.0 (awesome-print#392) Retire eol rubies (awesome-print#393) Use rails 5.2 when testing frozen strings Fix frozen string errors Run frozen string specs against ruby 2.6 Run builds against ruby 2.6 instead of head Lock rails 5 to correct sqlite3 version
obourdon
pushed a commit
to obourdon/awesome_print
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #391.
Ruby 3.0 changed the rules around how and when you can call Proc.new. This should fix the issue by complying with the new rules.