Skip to content

Commit

Permalink
Allow SMS testing with numbers that are not PhoneTypeCode 0 (#251)
Browse files Browse the repository at this point in the history
* Allow SMS testing with numbers that are not PhoneTypeCode 0

Not every number that can receive an SMS has PhoneTypeCode 0 - for example, Toll-free numbers that can be obtained through Pinpoint and used for
2-way messaging.

* Reinstate erroring for some not OK phone codes
  • Loading branch information
damiendaemon authored Aug 6, 2021
1 parent 5ca3c0b commit 431e635
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/users/src/users-service/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,9 @@ func UserVerifyAndUpdatePhone(w http.ResponseWriter, r *http.Request){
return
} else {
fmt.Println(res)
mobilePhoneCode := int(*res.NumberValidateResponse.PhoneTypeCode)
if (mobilePhoneCode != 0) {
var errMessage string = "The phone number provided is not a MOBILE phone number. The number is not capable of receiving SMS. Cannot create SMS endpoint for this number. Try entering a mobile phone number."
mobilePhoneType := aws.StringValue(res.NumberValidateResponse.PhoneType)
if (mobilePhoneType == "INVALID" || mobilePhoneType == "LANDLINE") {
var errMessage string = "The phone number provided is phone number of type " + mobilePhoneType + ". The number would not not be capable of receiving SMS. Cannot create SMS endpoint for this number. Try entering a valid phone number."
panic(errMessage)
http.Error(w, errMessage, 422)
return
Expand Down

0 comments on commit 431e635

Please sign in to comment.