Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SMS testing with numbers that are not PhoneTypeCode 0 #251

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Allow SMS testing with numbers that are not PhoneTypeCode 0 #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc56c7f
Allow SMS testing with numbers that are not PhoneTypeCode 0
damiendaemon Aug 4, 2021
9e07c48
Reinstate erroring for some not OK phone codes
damiendaemon Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/users/src/users-service/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,9 @@ func UserVerifyAndUpdatePhone(w http.ResponseWriter, r *http.Request){
return
} else {
fmt.Println(res)
mobilePhoneCode := int(*res.NumberValidateResponse.PhoneTypeCode)
if (mobilePhoneCode != 0) {
var errMessage string = "The phone number provided is not a MOBILE phone number. The number is not capable of receiving SMS. Cannot create SMS endpoint for this number. Try entering a mobile phone number."
mobilePhoneType := aws.StringValue(res.NumberValidateResponse.PhoneType)
if (mobilePhoneType == "INVALID" || mobilePhoneType == "LANDLINE") {
var errMessage string = "The phone number provided is phone number of type " + mobilePhoneType + ". The number would not not be capable of receiving SMS. Cannot create SMS endpoint for this number. Try entering a valid phone number."
panic(errMessage)
http.Error(w, errMessage, 422)
return
Expand Down