socket related from network_framework_integration branch #662
+2,321
−769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
commented
Sep 18, 2024
| struct nw_socket *socket_impl = socket->impl; | ||
|
|
||
| nw_socket->connect_args = aws_mem_calloc(socket->allocator, 1, sizeof(struct nw_socket_connect_args)); | ||
| if (!nw_socket->connect_args) { |
There was a problem hiding this comment.
we do not need to check result of an aws_mem_calloc
sbSteveK
commented
Sep 18, 2024
| nw_parameters_t socket_options_to_params; | ||
| struct aws_linked_list read_queue; | ||
| int last_error; | ||
| aws_socket_on_readable_fn *on_readable; | ||
| void *on_readable_user_data; | ||
| bool setup_run; | ||
| bool setup_closing; |
There was a problem hiding this comment.
Changing to "socket_closed". I think where this is used is not checking the transitory state of the socket but is instead simply checking whether it's open for use.
There was a problem hiding this comment.
On second thought, changed it to socket_open. We can start it as false and only flip it to true on a successful socket connection, and flip it back to false on a socket closure.
sbSteveK
commented
Sep 18, 2024
| @@ -73,18 +73,28 @@ enum socket_state { | |||
| CLOSED, | |||
| }; | |||
|
|
|||
| struct nw_socket_connect_args { | |||
There was a problem hiding this comment.
renaming this to nw_socket_timeout_args to better reflect what it's used for.
sbSteveK
commented
Sep 18, 2024
| bool read_queued; | ||
| bool is_listener; | ||
| struct nw_socket_connect_args *connect_args; |
There was a problem hiding this comment.
renaming to timeout_args for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Network Framework socket integration
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.