support require json file

[ahaoboy]

Description of changes

Support require json files

console.log( require('package.json') )

Checklist

• Created unit tests in tests/unit and/or in Rust for my feature if needed
• Ran make fix to format JS and apply Clippy auto fixes
• Made sure my code didn't add any additional warnings: make check
• Added relevant type info in types/ directory
• Updated documentation if needed (API.md/README.md/Other)

[richarddavison]

This is a great addition but should be done at import level instead of only supporting require.

[ahaoboy]

This is a great addition but should be done at import level instead of only supporting require.

Do you mean support for import a from './a.json'?
This should implement a JSONLoader, but nodejs not support this syntax

[richarddavison]

This is a great addition but should be done at import level instead of only supporting require.

Do you mean support for import a from './a.json'? This should implement a JSONLoader, but nodejs not support this syntax

It does not but does through import assertions. I think we can allow it in LLRT as well.
Also left another comment in the PR regarding evaluation of JSON.

[ahaoboy]

It does not but does through import assertions. I think we can allow it in LLRT as well.

This may be more troublesome than expected due to the confusing behavior of cjs and esm

If you use the json file as a js file that exports a js object by default

{ "a": 1 }

export default { "a": 1 } 

Then what we get is an object like this

const a = require('./a.json')

// { default: { a: 1} }

[richarddavison]

If you use the json file as a js file that exports a js object by default

What do you mean by this? :)

[ahaoboy]

What do you mean by this? :)

It might be easier to implement json import for require and import separately

use rquickjs::{loader::Loader, Ctx, Error, Module, Result};

#[derive(Debug)]
pub struct JSONLoader;

impl Loader for JSONLoader {
    fn load<'js>(&mut self, ctx: &Ctx<'js>, path: &str) -> Result<Module<'js>> {
        if !path.ends_with(".json") {
            return Err(Error::new_loading(path));
        }
        let source = std::fs::read_to_string(path)?;
        Module::declare(ctx.clone(), path, format!("export default ({source})"))
    }
}

[richarddavison]

Right I see what you mean. It might be better to have two separate implementations since there is no way to return an already created object from a module.

I would for the require function use json_parse and for the json loader use:

Module::declare(ctx.clone(), path, ["export default ", &source].concat())