Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init to url #584

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add init to url #584

merged 1 commit into from
Sep 11, 2024

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Sep 11, 2024

Description of changes

  • Moved the init from http to url to keep things contain (also the module didn't work otherwise because it needs the global to be set)

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will soon not be a problem once we refactor the module builder/init with the opaque feature

@richarddavison richarddavison merged commit dafc75f into awslabs:main Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants