-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upload artifacts #596
ci: upload artifacts #596
Conversation
6d162c9
to
66dd93f
Compare
https://github.com/awslabs/llrt/actions/runs/10925799624/job/30328199206
|
Hi @ahaoboy , The error I am getting in the Build Windows binaries section is caused by my previous PR. Specifically, when I refactored the makefile, I made an error in specifying the target file name for the zip. Can you please correct this in this PR?
Line 96 in 62b60c9
The correct information is as follows. // makefile
zip -j $$@ target/$$(TARGET_windows_$$(RELEASE_ARCH_NAME_${1}))/release/llrt.exe |
Thanks for your help |
https://github.com/ahaoboy/llrt/actions/runs/10937408801 I've tried using the msvc toolchain on the Windows platform and it seems to work too, though it's a little bit larger and there may be a timing inconsistency issue that I hesitate to add to ci |
Thanks LGTM! |
Description of changes
For the convenience of testing, upload the artifacts