Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup, More Options and a Bugfix. #158

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

Ceikry
Copy link
Contributor

@Ceikry Ceikry commented Aug 10, 2024

Changes Proposed:

  • Refactor of InvType and Subclass mismatch handling to allow for easier future extensibility
  • (Transmogrification.AllowLowerTiers) Add the ability to transmog into any tiered armor class the user can actually equip (e.g. Plate users can use all tiers, so can transmog into items from any tier, leather users can only use leather and cloth so can tmog into leather and cloth, etc.)
  • (Transmogrification.AllowMixedOffhandArmorTypes) Add the ability to transmog offhand armor types into any other offhand armor type (e.g. "Held in Off-hand" gear over shields and vice versa)
  • Allow MISC-subclass armor to be transmogrified over any armor tier as long as their types match (Helm and Helm, etc)

Issues Addressed:

Tests Performed:

  • Tested default config - works as expected
  • Tested AllowLowerTiers by itself - works as expected
  • Tested AllowMixedOffhandArmorTypes by itself - works as expected
  • Tested AllowLowerTiers, AllowMixedOffhandArmorTypes together - works as expected
  • Tested AllowMixedArmorTypes by itself - works as expected
  • Tested AllowMixedWeaponTypes 0,1,2 by itself - works as expected
  • Tested transmogging cosmetic items like the Forever Lovely Rose over any other headpiece - works as expected

How to Test the Changes:

  • Compile the module as normal
  • Test default transmog rules - only certain tiers allowed (source and target) by default, can only tmog Mail into Mail, Plate into Plate, etc.
  • Test AllowLowerTiers 1 - Should allow Plate wearers to tmog into Plate, Mail, Leather, Cloth. Mail into (Mail|Leather|Cloth). Leather into (Leather|Cloth) and Cloth into Cloth.
  • Test AllowMixedOffhandArmorTypes 1 - Should allow transmogging a shield over a "Held in Off-hand" item and vice versa
  • Test cosmetic pieces like those mentioned in the linked issue - should be able to transmog them over standard, non-cosmetic items.

Sorry, I know multiple things in one PR is bad practice but all 3 things just happened to be related to the same region of code I was working on.

@Ceikry Ceikry changed the title Add some stricter options than fully mixed armor types Code Cleanup, More Options and a Bugfix. Aug 11, 2024
src/Transmogrification.cpp Outdated Show resolved Hide resolved
@Helias Helias requested a review from Nyeriah August 14, 2024 10:58
@Nyeriah Nyeriah merged commit a571805 into azerothcore:master Aug 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic armour pieces without type arent transmoggable.
3 participants