Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mumble disconnection callback #57

Closed
ChamNouki opened this issue Mar 31, 2020 · 9 comments
Closed

Mumble disconnection callback #57

ChamNouki opened this issue Mar 31, 2020 · 9 comments
Assignees

Comments

@ChamNouki
Copy link

Could it be possible to have a PYMUMBLE_CLBK_DISCONNECTED like the PYMUMBLE_CLBK_CONNECTED one ?

@Lindenk
Copy link

Lindenk commented Apr 10, 2020

Also it doesn't seem like there is even a way to disconnect. That seems like a rather important feature

@azlux azlux self-assigned this Apr 10, 2020
@azlux
Copy link
Owner

azlux commented Apr 17, 2020

@Lindenk indeed. To disconnect, you need to kill the mumble object.
@ChamNouki I'm agree this callback isn't available. Current implementation stop the socket once the mumble object is disconnect. You want a callback to have reconnection actions ?

azlux added a commit that referenced this issue Apr 17, 2020
@azlux
Copy link
Owner

azlux commented Apr 18, 2020

Can you check now, should be fix.

@wasauce
Copy link

wasauce commented Apr 20, 2020

@azlux - what do you mean kill the mumble object?

What would the preferred way to do this be please? We currently just let it timeout. But I'd be happy to set it to None or some other method to kill the object when we are done processing.

@azlux
Copy link
Owner

azlux commented Apr 22, 2020

@Lindenk @wasauce After digging, I've create a separate issue because I need to add some code. #61

@ChamNouki
Copy link
Author

ChamNouki commented Apr 25, 2020

PYMUMBLE_CLBK_DISCONNECTED seems to work perfectly. Even though PYMUMBLE_CLBK_CONNECTED is not called when connection is back. Trying to find why but it seems that we never pass in the if at line 314 in mumble.py and I don't understand why.

@azlux azlux reopened this Apr 25, 2020
@ChamNouki
Copy link
Author

Not passing in the if at line 314 in mumble.py seems to be link to #63

@azlux
Copy link
Owner

azlux commented May 3, 2020

can we follow this issue on #63 ?

@azlux azlux closed this as completed May 3, 2020
@ChamNouki
Copy link
Author

sure we can ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants