Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node.js v18 #21

Closed
wants to merge 3 commits into from
Closed

Update to node.js v18 #21

wants to merge 3 commits into from

Conversation

jtsaito
Copy link
Contributor

@jtsaito jtsaito commented Jul 6, 2023

Depends on

This enables

@jtsaito jtsaito self-assigned this Jul 6, 2023
@jtsaito jtsaito requested a review from a team July 6, 2023 09:44
@jtsaito jtsaito added the dependencies Pull requests that update a dependency file label Jul 6, 2023
@jtsaito
Copy link
Contributor Author

jtsaito commented Jul 6, 2023

@jansiwy It seems we cannot do this update because GitHub actions does not support node.js 18 for custom actions yet

I think we should still roll out the refactored API calls and tests.

@jansiwy
Copy link
Member

jansiwy commented Jul 6, 2023

@jtsaito then please open a support tickets because it's kind of weird if GitHub has deprecated node.js 16 in octokit, but is not supporting node.js 18 in GitHub Actions.

@jtsaito jtsaito mentioned this pull request Jul 6, 2023
1 task
Base automatically changed from fetch-mock to class-for-api-calls July 7, 2023 08:57
Base automatically changed from class-for-api-calls to main July 7, 2023 08:58
@jtsaito
Copy link
Contributor Author

jtsaito commented Jul 7, 2023

I'm closing this because we have to wait for GitHub to support node.js 18 for GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

2 participants