Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not inject the same imported identifier multiple times #16370

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ota-meshi
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #16369
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes issue #16369.
I added one test case to check that it is resolved.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56556

@ota-meshi
Copy link
Contributor Author

I'm not sure why the Third-party Parser Tests failed 😓 Could you give me some advice? 🙏

@liuxingbaoyu
Copy link
Member

That's an unrelated random network failure, nothing to worry about!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! There is also another regression that we are working on, then I'll release a patch.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Mar 20, 2024
@nicolo-ribaudo nicolo-ribaudo changed the title fix(babel-helper-module-imports): import same identifier multiple times fix: do not inject the same imported identifier multiple times Mar 20, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit 3a6683b into babel:main Mar 20, 2024
50 of 51 checks passed
@ota-meshi ota-meshi deleted the fix-16369 branch March 20, 2024 11:05
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Import the same identifier multiple times in jsx transform.
4 participants