Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SensorModel and use throughout library #14

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Create SensorModel and use throughout library #14

merged 3 commits into from
Nov 7, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 7, 2022

Describe what the PR does:

Until now, we returned sensors as dictionaries. This PR introduces SensorModel and uses it throughout the library.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the maintenance Generic library tasks label Nov 7, 2022
@bachya bachya self-assigned this Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #14 (451b906) into dev (085d0b9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               dev       #14    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        11            
  Lines          246       416   +170     
==========================================
+ Hits           246       416   +170     
Impacted Files Coverage Δ
aiopurpleair/const.py 100.00% <100.00%> (ø)
aiopurpleair/helpers/validators/sensors.py 100.00% <100.00%> (ø)
aiopurpleair/models/sensors.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codeclimate
Copy link

codeclimate bot commented Nov 7, 2022

Code Climate has analyzed commit 451b906 and detected 0 issues on this pull request.

View more on Code Climate.

@bachya bachya changed the title Create SensorModel and use throughout library Create SensorModel and use throughout library Nov 7, 2022
@bachya bachya merged commit 0f0d1ac into dev Nov 7, 2022
@bachya bachya deleted the sensor-model branch November 7, 2022 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant