Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with API.sensors.async_get_sensor not resolving #23

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 22, 2022

Describe what the PR does:

We were looking at the wrong endpoint (/v1/sensor/:sensor_index when it should be /v1/sensors/:sensor_index).

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Nov 22, 2022
@bachya bachya self-assigned this Nov 22, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit ee5ba65 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #23 (ee5ba65) into dev (16a7479) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          481       481           
=========================================
  Hits           481       481           
Impacted Files Coverage Δ
aiopurpleair/endpoints/sensors.py 100.00% <ø> (ø)
aiopurpleair/models/sensors.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit db6269c into dev Nov 22, 2022
@bachya bachya deleted the sensor-endpoint branch November 22, 2022 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant