generated from bachya/pypi-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model for GET /v1/sensors requests #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachya
added
the
enhancement
Enhancement of the code, not introducing new features.
label
Nov 3, 2022
Codecov Report
@@ Coverage Diff @@
## dev #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 4 +2
Lines 31 99 +68
=========================================
+ Hits 31 99 +68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Code Climate has analyzed commit 7942d89 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
SSIA
Note the use of
Optional
here instead of the more modern|
operator. This is because of Pydantic on pre-Python 3.10: pydantic/pydantic#3300 (comment)Since the primary purpose of this library is to support Home Assistant and HASS currently supports Python 3.9, we also need to. Once Python 3.12 is released, we can upgrade the syntax.
Does this fix a specific issue?
N/A
Checklist:
README.md
with any new documentation.AUTHORS.md
.