-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugins API #578
Add plugins API #578
Conversation
@CherryPerry @mk-jones @saket Here is a draft of plugins API. Could you please review? When this will be finalised for Observable I will expand it for other source types. Also added usage example to the MainActivity. Thanks! |
Sorry, I do not have any experience with RxJava plugins, so I can't review it from API client perspective. |
@CherryPerry Maybe you could just add your general thoughts about the API. The idea is to provide an ability to wrap all created sources with custom middlewares. |
LGTM. Wanna add some documentation to |
reaktive/src/jvmJsCommonMain/kotlin/com/badoo/reaktive/observable/plugins/ObservablePlugins.kt
Outdated
Show resolved
Hide resolved
reaktive/src/jvmJsCommonMain/kotlin/com/badoo/reaktive/observable/plugins/ObservablePlugins.kt
Outdated
Show resolved
Hide resolved
sample-android-app/src/main/java/com/badoo/reaktive/sample/android/MainActivity.kt
Outdated
Show resolved
Hide resolved
90b355c
to
f766f2b
Compare
reaktive/src/commonMain/kotlin/com/badoo/reaktive/plugin/ReaktivePluginsExt.kt
Outdated
Show resolved
Hide resolved
reaktive/src/commonMain/kotlin/com/badoo/reaktive/plugin/SimpleReaktivePlugin.kt
Outdated
Show resolved
Hide resolved
6ecaccb
f766f2b
to
6ecaccb
Compare
reaktive/src/commonMain/kotlin/com/badoo/reaktive/plugin/ReaktivePluginsExt.kt
Outdated
Show resolved
Hide resolved
Native tests are crashing, I will fix |
@CherryPerry I added two commits:
|
Add plugins API for Reaktive sources wrapping.
Closes #574